Skip to content

[PropertyInfo] Deprecate Type#9

Closed
mtarld wants to merge 382 commits intochore/type-info-componentfrom
chore/deprecate-property-info-type
Closed

[PropertyInfo] Deprecate Type#9
mtarld wants to merge 382 commits intochore/type-info-componentfrom
chore/deprecate-property-info-type

Conversation

@mtarld
Copy link
Copy Markdown
Owner

@mtarld mtarld commented Oct 26, 2023

No description provided.

@mtarld mtarld force-pushed the chore/type-info-component branch from bddcb4d to 5feec6a Compare October 26, 2023 09:35
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 567a3dd to 89e20c8 Compare October 26, 2023 09:36
@mtarld mtarld force-pushed the chore/type-info-component branch from 5feec6a to 41c48f2 Compare October 26, 2023 09:37
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch 4 times, most recently from 665e35a to 1d60a2e Compare October 27, 2023 11:40
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 647fe5a to 23c581f Compare November 3, 2023 11:03
@mtarld mtarld force-pushed the chore/type-info-component branch from 41c48f2 to 1e332a2 Compare November 3, 2023 11:13
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 23c581f to 1a5e1d2 Compare November 3, 2023 11:21
@mtarld mtarld force-pushed the chore/type-info-component branch from 1e332a2 to 2bd39f0 Compare November 6, 2023 02:34
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 1a5e1d2 to 42d5412 Compare November 6, 2023 02:39
@mtarld mtarld force-pushed the chore/type-info-component branch from 2bd39f0 to 2f1e0c9 Compare November 6, 2023 10:45
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 42d5412 to 156eafa Compare November 6, 2023 10:45
Copy link
Copy Markdown
Collaborator

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Korbeil Korbeil force-pushed the chore/type-info-component branch from 2f1e0c9 to 1e96d87 Compare November 6, 2023 21:23
@mtarld mtarld force-pushed the chore/type-info-component branch from 1e96d87 to 1a20715 Compare November 7, 2023 02:29
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 156eafa to 626b53c Compare November 7, 2023 02:40
@mtarld mtarld force-pushed the chore/type-info-component branch from 1a20715 to 7fd384d Compare November 7, 2023 02:40
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 626b53c to 3c14904 Compare November 7, 2023 02:41
@mtarld mtarld force-pushed the chore/type-info-component branch from 7fd384d to 323b986 Compare November 7, 2023 03:26
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 3c14904 to 8f5de1b Compare November 7, 2023 03:37
@mtarld mtarld force-pushed the chore/type-info-component branch from 323b986 to d03e987 Compare November 8, 2023 03:26
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 8f5de1b to 414d69f Compare November 8, 2023 03:45
@mtarld mtarld changed the title [TypeInfo][PropertyInfo] Deprecate PropertyInfo Type [PropertyInfo] Deprecate PropertyInfo Type Nov 8, 2023
@mtarld mtarld changed the title [PropertyInfo] Deprecate PropertyInfo Type [PropertyInfo] Deprecate Type Nov 8, 2023
@mtarld mtarld force-pushed the chore/type-info-component branch from d03e987 to 5efdeb3 Compare November 8, 2023 04:05
@mtarld mtarld force-pushed the chore/deprecate-property-info-type branch from 414d69f to 6edee23 Compare November 8, 2023 04:17
xabbuh and others added 30 commits February 3, 2024 19:45
…n a new line (maxbeckers)"

This reverts commit 40a2cfb, reversing
changes made to d2d36b5.
The order in which the properties are handled has changed with the usage
of CPP for the entity manager in doctrine/orm#11205.
…arser with quote end in a newline (maxbeckers)" (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[Yaml] Revert "feature symfony#48022  Fix Yaml Parser with quote end in a newline (maxbeckers)"

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Unfortunately, the features as implemented breaks tests in other bundles (see https://github.com/symfony/symfony/actions/runs/7768721075/job/21186968515?pr=53745#step:8:3092).

Commits
-------

d709af0 Revert "feature symfony#48022 [Yaml] Fix Yaml Parser with quote end in a new line (maxbeckers)"
This PR was merged into the 6.4 branch.

Discussion
----------

[VarDumper] fix DoctrineCaster tests

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

The order in which the properties are handled has changed with the usage of CPP for the entity manager in doctrine/orm#11205.

Commits
-------

e7e41b0 fix DoctrineCaster tests
…e handled (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[TwigBridge] rework the way excluded directories are handled

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

This change ensures that we not break BC by reverting the signature change made to the protected findFiles() method.

Commits
-------

3074fe8 rework the way excluded directories are handled
… the schema definition (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[SecurityBundle] add missing partition attribute to the schema definition

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

867eb07 add missing partition attribute to the schema definition
This PR was merged into the 7.1 branch.

Discussion
----------

[DependencyInjection] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

3883a07 fix tests
* 6.4:
  fix DoctrineCaster tests
  add missing partition attribute to the schema definition
* 7.0:
  fix DoctrineCaster tests
  add missing partition attribute to the schema definition
…entication (bytestream)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

Fix client side connection timeout breaks mail authentication

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#53647
| License       | MIT

The authentication loop should only continue when an unexpected response has been received. Any other exception, for example,  `throw new TransportException('Connection to "localhost" timed out.'));` should be treated as fatal and thrown.

As demonstrated in symfony#53647, when anything other than a server response is skipped it results in later commands not matching their expected response codes.

Commits
-------

bb2e7fd Fix client side connection timeout breaks mail authentication
* 6.4:
  Fix client side connection timeout breaks mail authentication
* 7.0:
  Fix client side connection timeout breaks mail authentication
Using constructor property promotion for the $metaFile property does not
make much sense for two reasons:

* We need to declare it nullable just for the sake of the constructor
  accepting null while the property itself will always receive a string.
* The initially set value is immediately overwritten in the constructor.
…xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[Config] replace CPP with non-nullable property

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Using constructor property promotion for the `$metaFile` property does not make much sense for two reasons:

* We need to declare it nullable just for the sake of the constructor accepting `null` while the property itself will always receive a string.
* The initially set value is immediately overwritten in the constructor.

Commits
-------

9c19bfe replace CPP with non-nullable property
… error (smnandre)

This PR was merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Improve import_polyfill configuration error

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#53725
| License       | MIT

Add missing error when 'asset_mapper.importmap_polyfill' is set to true
(only false and string are allowed)

Commits
-------

050fe20 [AssetMapper] Improve import_polyfill configuration error
* 6.4:
  [AssetMapper] Improve import_polyfill configuration error
* 7.0:
  [AssetMapper] Improve import_polyfill configuration error
…tream)

This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Mailer] Add timestamp to SMTP debug log

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT

When debugging symfony#53647, the lack of a timestamp made it difficult to understand why the `RSET` was happening before a response had been received. The timestamps gave a clue towards the problem. The timestamps also help show slow connections which you're otherwise not aware of.

Commits
-------

53a637c [Mailer] Add timestamp to SMTP debug log
…appings in Doctrine ORM 4 (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[DoctrineBridge] forward-compatibility with field mappings in Doctrine ORM 4

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

see doctrine/orm#11211

Commits
-------

264f7fc forward-compatibility with field mappings in Doctrine ORM 4
* 5.4:
  forward-compatibility with field mappings in Doctrine ORM 4
* 6.4:
  forward-compatibility with field mappings in Doctrine ORM 4
* 7.0:
  forward-compatibility with field mappings in Doctrine ORM 4
Co-authored-by: Baptiste Leduc <baptiste.leduc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.