-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Comparing changes
Open a pull request
base repository: git-for-windows/git
base: main
head repository: msysgit/git
compare: tmp-symlink
- 12 commits
- 21 files changed
- 2 contributors
Commits on May 14, 2014
-
MinGW: Add symlink support for NTFS on windows
This patch implements git support for NTFS symbolic link type reparse points. * There is a specific privelege required to create symbolic links that is not generally associated with a standard user. This part is up to the user to worry about. * NTFS reparse points differentiate between file and directory links. This patch assumes file links are meant. (A separate patch will develop this further). * This patch is not intended to implement symbolic links in the shell utilities. This means that as of when this was written, bash and gnu utilities do not handle them. * Windows chdir behaves differently to *nix, and we need to unravel symbolic links for various operations to work as expected. * For efficiency, as much as possible of the calls are done with wchar_t, before being converted to utf-8. This is as much about avoiding dealing with windows default encoding as anything else. * resolve_symlink needed to be replaced in lockfile.c since there are some issues with recognising absolute paths, as well as for efficiency with wchar_t. This work was based on a combination of patches developed by the following people: original-by: Johannes Schindelin <johannes.schindelin@gmx.de> original-by: Thorvald Natvig <slicer@users.sourceforge.net> Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for 29272bc - Browse repository at this point
Copy the full SHA 29272bcView commit details -
MinGW: Allow passing the symlink target type from index information.
Required for msysgit which needs to know whether the target of a symbolic link is a directory or file. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for fa9215f - Browse repository at this point
Copy the full SHA fa9215fView commit details -
mingw: Create directory/file symlink from information available
Windows NTFS symbolic links require specifying whether the target is a file or directory at creation time. This can partially be done by interrogating the filesystem, however when creating symbolic links that are within a repository, there can be no guarantee of the order of creation. This patch enables the code to allow interrogation of the git cache to determine whether a target will be a file or a directory. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for bdaef2c - Browse repository at this point
Copy the full SHA bdaef2cView commit details -
test: Work around lack of windows native symlink support in current msys
The current msys does not have support for NTFS symlinks. This includes in 'ln', 'test', 'rm'. Here the commands are overridden to use windows cmd.exe instead of msys. The implementation of test is quite expensive but works for the test. 'rm' needs to handle many scenarios. Symlinks are not supported at all by the msys version. * 'rm -rf' equivalent needs to first delete the files, and then the directories. * Directory symbolic links need to use cmd.exe 'rmdir' * file symbolic links need to use 'del'. * A couple of places use 'rm -rf' on a mix of files and directories, so needs to be split up. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for 99c19fa - Browse repository at this point
Copy the full SHA 99c19faView commit details
Commits on May 15, 2014
-
test: Don't have dangling symlinks in tests (for msys)
There are 2 reasons for this: * Under windows, ln() must determine whether the target is a directory or a file before creating the link. * msys doesn't handle dangling NTFS symlinks well (for example 'ls' will abort at that point, claiming the file doesn't exist). So I have reordered commands to make sure our symlinks don't dangle from the time of their creation. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>Configuration menu - View commit details
-
Copy full SHA for feb5e09 - Browse repository at this point
Copy the full SHA feb5e09View commit details -
test: Factor abspath_of_dir for testing 'absolute paths'
Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for a93ce43 - Browse repository at this point
Copy the full SHA a93ce43View commit details -
test: Implement mingw abspath_of_dir
needed to translate /c/ -> c: for comparison. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for 6ed7452 - Browse repository at this point
Copy the full SHA 6ed7452View commit details -
test: Factor out 'check_symlink' for stash tests
Required by msysgit while the msys core does not handle reading NTFS Symbolic-Link Reparse Points. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for 8dc4b93 - Browse repository at this point
Copy the full SHA 8dc4b93View commit details -
test: Override 'check_symlink' to work with incomplete mingw
Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for e58ba15 - Browse repository at this point
Copy the full SHA e58ba15View commit details -
contrib: make git-new-workdir work with windows symlinks.
Required for tests to work. Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for 922dba7 - Browse repository at this point
Copy the full SHA 922dba7View commit details -
test: Differentiate ability for gnu utils to handle symlinks from git
t7800 failed under symlink enabled msysgit without symlink enabled perl/msys Signed-off-by: Michael Geddes <michael@frog.wheelycreek.net>
Configuration menu - View commit details
-
Copy full SHA for a952ec3 - Browse repository at this point
Copy the full SHA a952ec3View commit details
Commits on May 16, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 6295284 - Browse repository at this point
Copy the full SHA 6295284View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...tmp-symlink