Skip to content

chore: replace missing ServiceWorkerIncomingRequest with IncomingWorkerRequest#2722

Merged
kettanaito merged 1 commit into
mainfrom
chore/fix-service-worker-incoming-request-type
Apr 17, 2026
Merged

chore: replace missing ServiceWorkerIncomingRequest with IncomingWorkerRequest#2722
kettanaito merged 1 commit into
mainfrom
chore/fix-service-worker-incoming-request-type

Conversation

@kettanaito

@kettanaito kettanaito commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@kettanaito kettanaito changed the title chore: replace missing ServiceWorkerIncomingRequest with `IncomingW… chore: replace missing ServiceWorkerIncomingRequest with IncomingWorkerRequest Apr 17, 2026
@coderabbitai

coderabbitai Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ab07afcc-cb6d-46c3-9fd7-b15dce963f3c

📥 Commits

Reviewing files that changed from the base of the PR and between 20521b9 and e915619.

📒 Files selected for processing (2)
  • src/browser/utils/deserializeRequest.ts
  • src/browser/utils/pruneGetRequestBody.ts
📝 Walkthrough

Walkthrough

Type annotations in utility functions are updated to use IncomingWorkerRequest instead of ServiceWorkerIncomingRequest, with pruneGetRequestBody return type widened to include undefined. Runtime behavior remains unchanged.

Changes

Cohort / File(s) Summary
Type Migration to IncomingWorkerRequest
src/browser/utils/deserializeRequest.ts, src/browser/utils/pruneGetRequestBody.ts		 Updated parameter and return types to use IncomingWorkerRequest from workerChannel instead of ServiceWorkerIncomingRequest. Return type of pruneGetRequestBody widened to `IncomingWorkerRequest['body']

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A type swap, so neat and clean,
IncomingWorker takes the scene,
No logic changed, just cleaner names,
The code still runs in all its frames! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-service-worker-incoming-request-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kettanaito kettanaito merged commit edeb058 into main Apr 17, 2026
12 of 15 checks passed
@kettanaito kettanaito deleted the chore/fix-service-worker-incoming-request-type branch April 17, 2026 21:40
@kettanaito

kettanaito commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

Released: v2.13.5 🎉

This has been released in v2.13.5.

Get these changes by running the following command:

npm i msw@latest

Predictable release automation by Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kettanaito