fix(HttpResponse): accept interfaces as json response-data type#1481
Merged
kettanaito merged 1 commit intoNov 28, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f92748:
|
kettanaito
approved these changes
Nov 28, 2022
kettanaito
left a comment
Member
There was a problem hiding this comment.
Simply great! Thanks, @christoph-fricke 👏
If you spot any other type issues with the next release, please let me know/open a pull request. Let's build the future of API mocking together.
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for an issue discussed with the upcoming standard-api. The relevant discussion can be found here: #1464 (comment)
TLDR: Objects that are typed with an interface cannot be assigned to
HttpResponse.json.This PR changes the generic of
HttpResponse.jsonto extendDefaultBodyTypeinstead of the similar yet slightly different union. I think it makes more sense (and fixes the issue), because the response generic of resolver functions and generic ofStrictResponsealso extendDefaultBodyType.