Merged
Conversation
f2eeac7 to
50efa1d
Compare
50efa1d to
02d2a0c
Compare
kettanaito
commented
Nov 11, 2021
| * using the "mock" response source. | ||
| */ | ||
| static suppressErrorCodes = ['ENOTFOUND', 'ECONNREFUSED'] | ||
| static suppressErrorCodes = ['ENOTFOUND', 'ECONNREFUSED', 'ECONNRESET'] |
Member
Author
There was a problem hiding this comment.
Adding ECONNRESET to the list of suppressed socket errors.
kettanaito
commented
Nov 11, 2021
| private responseSource: 'mock' | 'bypass' = 'mock' | ||
| private capturedError?: NodeJS.ErrnoException | ||
|
|
||
| public requestBody: Buffer[] = [] |
Member
Author
There was a problem hiding this comment.
Making requestBody public so it can be directly asserted in tests.
| ) | ||
| // Write the last request body chunk to the internal request body buffer. | ||
| if (chunk) { | ||
| this.requestBody = concatChunkToBuffer(chunk, this.requestBody) |
Member
Author
There was a problem hiding this comment.
Concatenating the last chunk provided to .end() so it becomes a part of the this.requestBody.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.