Skip to content

Handle optional chaining in missing-playwright-await#472

Merged
mskelton merged 1 commit into
mskelton:mainfrom
morgan-coded:fix/467-optional-chaining-await
Jul 1, 2026
Merged

Handle optional chaining in missing-playwright-await#472
mskelton merged 1 commit into
mskelton:mainfrom
morgan-coded:fix/467-optional-chaining-await

Conversation

@morgan-coded

Copy link
Copy Markdown
Contributor

missing-playwright-await could report awaited optional-chained Playwright calls, such as await page?.unrouteAll().

This treats the ChainExpression wrapper as transparent while walking the awaited call. I checked the repro red-to-green and ran the full test/CI checks with 3,309 tests passing.

Fixes #467

Copilot AI review requested due to automatic review settings June 29, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mskelton mskelton merged commit c02becc into mskelton:main Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing-playwright-await gives false positive when using optional chaining (?.) on page methods

3 participants