Add testsuite for ARM64 logical immediate encoding/decoding#47
Closed
xclerc wants to merge 1 commit intomshinwell:arm64-typed-dslfrom
Closed
Add testsuite for ARM64 logical immediate encoding/decoding#47xclerc wants to merge 1 commit intomshinwell:arm64-typed-dslfrom
xclerc wants to merge 1 commit intomshinwell:arm64-typed-dslfrom
Conversation
Add a comprehensive test for the ARM64 logical immediate encoding and decoding implementation in backend/arm64/ast/logical_immediates.ml. The test: - Exhaustively tests all 8,192 possible (n, immr, imms) field combinations - Verifies that valid encodings can be decoded and re-encoded correctly - Tests 10 million random values to ensure proper rejection of invalid immediates (takes approximately 4 seconds) - Includes a reference decoder implementation for validation The test is located in oxcaml/tests/backend/arm64-logical-immediate/ and uses dune to reference the arm64_ast library, avoiding code duplication by using the actual logical_immediates module. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Owner
|
Has been cherry-picked and merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a comprehensive test for the ARM64 logical immediate encoding and decoding implementation in backend/arm64/ast/logical_immediates.ml.
The test:
The test is located in oxcaml/tests/backend/arm64-logical-immediate/ and uses dune to reference the arm64_ast library, avoiding code duplication by using the actual logical_immediates module.
🤖 Generated with Claude Code