Fix the Cmm code for cache_public_method#46
Merged
mshinwell merged 1 commit intomshinwell:remove-cassignfrom Mar 24, 2025
Merged
Fix the Cmm code for cache_public_method#46mshinwell merged 1 commit intomshinwell:remove-cassignfrom
mshinwell merged 1 commit intomshinwell:remove-cassignfrom
Conversation
lthls
commented
Mar 21, 2025
mshinwell
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't checked exactly how the previous version was wrong, but since I knew the bug came from this code I just rewrote it from scratch, in what I hope is a slightly less obscure way.
I'll note that it was more readable when I wrote it, but then ocamlformat went through and now a few places are hard to read.