Add %makearray_dynamic tests#45
Merged
mshinwell merged 5 commits intomshinwell:makearray_dynamicfrom Dec 18, 2024
Merged
Conversation
e0e3cfd to
e564489
Compare
e564489 to
131a2cf
Compare
%makearray_dynamic tests%makearray_dynamic tests and move %makearray_dynamic_uninit to beta
%makearray_dynamic tests and move %makearray_dynamic_uninit to beta%makearray_dynamic tests & move %makearray_dynamic_uninit to beta
%makearray_dynamic tests & move %makearray_dynamic_uninit to beta%makearray_dynamic tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%makearray_dynamictests (131a2cf) (see below)%makearray_dynamic_uninittolayouts_beta(fromlayouts_alpha) (b719e45)gen_product_array_helpers.mlinfra to test%makearay_dynamic_uninit(4ce5167) and unboxed float arrays(9c07d0f)
%makearray_dynamic_uninitonly accepts GC-ignored layouts (3e16c1c)Generated tests
We generate tests for uninitialized/initialized heap/local arrays of various types and sizes. For each such array, we do the following.
We only perform steps 7-9 for arrays whose elements are GC-ignorable. This can be changed once blits work for all arrays.
The tests are generated by
testsuite/tests/typing-layouts-arrays/generate_makearray_dynamic_tests.ml. This generatestestsuite/tests/typing-layouts-arrays/generated_test.ml. This test caught the bug fixed by 8651275 (minimal example).The test generator is loosely based on
testsuite/tests/mixed-blocks/generate_mixed_blocks_code.ml.