Fix parsing roundtrip error in raw idents#38
Merged
mshinwell merged 2 commits intomshinwell:5.2-runtime-wip-mainfrom Aug 27, 2024
Merged
Conversation
ccasin
approved these changes
Aug 22, 2024
ccasin
left a comment
There was a problem hiding this comment.
These changes look good, sorry I missed this in initial review.
I think there is one more missing: I can't leave a comment there, but upstream has a ident_of_name on the Pexp_newtype case of the pp_print_pexp_function helper in binding. I think the equivalent on our side should be to add it at in the printer for the result of tyvars_str on line 1764 in your version of the file
Author
|
Thanks for checking that — I agree that it's a bug, but disagree that it corresponds to $ opam exec --switch=5.2.0 -- ocaml -dsource
OCaml version 5.2.0
Enter #help;; for help.
# let f : type \#let. \#let -> \#let = fun x -> x;;
let f : type let. \#let -> \#let = fun x -> x;;which is not to say that we shouldn't fix it, but that I'm just going to file an issue upstream. |
Author
|
@mshinwell please merge this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge dropped a bunch of
ident_of_nameforPexp_newtypes; this PR reintroduces them to get the pprintast parsetree test to pass.