Accept corrections for w53 test merge#34
Merged
mshinwell merged 1 commit intomshinwell:5.2-runtime-wip-mainfrom Aug 21, 2024
Merged
Conversation
Author
|
@ccasin Could you please review? |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge of the w53 fix in oxcaml#2912 did not accept corrections to test output as the test suite wasn't building yet. This PR just accepts corrections to the test output.
The diff is unreadably large. How did I confirm that the new test output is reasonable? I checked that the only attributes that are rejected are the ones commented as
(* rejected *)in the test.I first confirmed that "accepted" doesn't show up at all in the test output.
I then ran the following two commands:
(* rejected *)comments in the source file.misplaced-attributewarnings that show up in the output.What explains the diff of 7? Let's look at the unmatched warning output:
The "reject second" cases are missed by my first grep, and should only add 1 unused attribute to the output. So those explain 3 of the missing cases. The other 4 are explained by the
tail_mod_conscases, where the(* rejected *)comment is on a different line than the attributes.