Skip to content

Simplify logic around rebuilding of End_region primitives#18

Merged
mshinwell merged 1 commit intomshinwell:delete-unused-regionsfrom
lthls:end_region_rebuilding
Sep 21, 2022
Merged

Simplify logic around rebuilding of End_region primitives#18
mshinwell merged 1 commit intomshinwell:delete-unused-regionsfrom
lthls:end_region_rebuilding

Conversation

@lthls
Copy link
Copy Markdown

@lthls lthls commented Sep 21, 2022

The idea behind this refactoring:

  • A first case for the simple case where we know we're not going to drop the primitive: if it is an used End_region, or if it has non-generative effects
  • A second case where we check for the possibility to delete it, or make it phantom. If it is an unused End_region, it gets into the deleted case.

@lthls lthls requested a review from mshinwell as a code owner September 21, 2022 15:47
@mshinwell mshinwell merged commit c52a055 into mshinwell:delete-unused-regions Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants