Cleaner way to handle my_region in to_cmm_env#17
Closed
Gbury wants to merge 12 commits intomshinwell:delete-unused-regionsfrom
Closed
Cleaner way to handle my_region in to_cmm_env#17Gbury wants to merge 12 commits intomshinwell:delete-unused-regionsfrom
Gbury wants to merge 12 commits intomshinwell:delete-unused-regionsfrom
Conversation
4749264 to
bd807d5
Compare
Author
|
This is not needed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be better than creating a dummy binding.
With this patch, the compilation of the stdlib fails because there is an (unused)
let region = my_regionwhich triggers an unbound error from selection. Not sure how to fix that yet, but we should be able to remove or not generate such unused binding I suppose ?