Merged
Conversation
Eliminated redundant zone allocation in unpacking process. ARRAY and MAP is construced on the zone. STR, BIN, and EXT refer to unpack buffer, and the buffer is reference counted via zone (finalizer). So zone is only needed if those types are appeared during unpacking process. I set zone to NULL by default. And the context has the pointer to pointer to the zone. If the context meets ARRAY, MAP, STR, BIN, or EXT, and zone (via pointer) is NULL, then allocate new zone. It is lazy zone allocation strategy.
|
This does solve #746 in my environment. Nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated redundant zone allocation in unpacking process.
ARRAY and MAP is construced on the zone.
STR, BIN, and EXT refer to unpack buffer, and the buffer is reference
counted via zone (finalizer).
So zone is only needed if those types are appeared during unpacking
process.
I set zone to NULL by default. And the context has the pointer to
pointer to the zone. If the context meets ARRAY, MAP, STR, BIN, or EXT,
and zone (via pointer) is NULL, then allocate new zone.
It is lazy zone allocation strategy.