Skip to content

fix(manage_asset): improve properties parameter parsing#6

Closed
dsarno wants to merge 1 commit into
msanatan:use-uvxfrom
dsarno:fix/manage-asset-properties-parsing
Closed

fix(manage_asset): improve properties parameter parsing#6
dsarno wants to merge 1 commit into
msanatan:use-uvxfrom
dsarno:fix/manage-asset-properties-parsing

Conversation

@dsarno

@dsarno dsarno commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown

This is a pet issue of mine, making sure we don't error out so much when dealing with material properties. Also caught a couple syntax errors in telemetry test from project changes

  • Update type annotation to accept dict[str, Any] | str for properties parameter
  • Add robust parsing logic that tries JSON first, then ast.literal_eval for Python dict strings
  • Log warning and pass through unparseable strings to Unity (for backward compatibility)
  • Add detailed logging to track how properties are received and parsed
  • Fix syntax errors in test_telemetry.py (missing 'from' in import statements)
  • All 82 tests now pass successfully

@dsarno
fix(manage_asset): improve properties parameter parsing with fallback…
c07c762 
… handling

- Update type annotation to accept dict[str, Any] | str for properties parameter
- Add robust parsing logic that tries JSON first, then ast.literal_eval for Python dict strings
- Log warning and pass through unparseable strings to Unity (for backward compatibility)
- Add detailed logging to track how properties are received and parsed
- Fix syntax errors in test_telemetry.py (missing 'from' in import statements)
- All 82 tests now pass successfully
@coderabbitai

coderabbitai Bot commented Nov 21, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Comment @coderabbitai help to get the list of available commands and usage tips.

@msanatan

msanatan commented Nov 25, 2025

Copy link
Copy Markdown
Owner

Took the code and applied it on the use-uvx directly to avoid the merge conflicts. Thanks @dsarno !

@msanatan msanatan closed this Nov 25, 2025
@dsarno dsarno deleted the fix/manage-asset-properties-parsing branch November 26, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsarno @msanatan