Skip to content

Update "scss-symbols-parser" package#93

Merged
mrmlnc merged 1 commit intomasterfrom
update_scss_symbols_parser
Nov 23, 2019
Merged

Update "scss-symbols-parser" package#93
mrmlnc merged 1 commit intomasterfrom
update_scss_symbols_parser

Conversation

@mrmlnc
Copy link
Copy Markdown
Owner

@mrmlnc mrmlnc commented Nov 23, 2019

This version has two fixes:

Fix incorrect early exit for unsupported at-rules

Related to Bootstrap@4+.

$grid-breakpoints: (
  xs: 0,
  sm: 576px,
  md: 768px,
  lg: 992px,
  xl: 1200px
) !default;

@include _assert-ascending($grid-breakpoints, "$grid-breakpoints"); // The parser broke down here
@include _assert-starts-at-zero($grid-breakpoints, "$grid-breakpoints");

$container-max-widths: (
  sm: 540px,
  md: 720px,
  lg: 960px,
  xl: 1140px
) !default;

@include _assert-ascending($container-max-widths, "$container-max-widths");

Fix mixin parsing without parameters

@mixin f {
	border-top: 0;
	border-right: $a solid transparent;  // previously it was considered a global variable
}

@mrmlnc mrmlnc force-pushed the update_scss_symbols_parser branch from 94d5b8e to 4e089da Compare November 23, 2019 11:10
@mrmlnc mrmlnc added this to the 0.8.1 milestone Nov 23, 2019
@mrmlnc mrmlnc merged commit f172e29 into master Nov 23, 2019
@mrmlnc mrmlnc deleted the update_scss_symbols_parser branch November 23, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant