Skip to content

Add functionality to open file after duplicate + configuration option#41

Merged
mrmlnc merged 3 commits intomrmlnc:masterfrom
dougshamoo:master
Aug 8, 2017
Merged

Add functionality to open file after duplicate + configuration option#41
mrmlnc merged 3 commits intomrmlnc:masterfrom
dougshamoo:master

Conversation

@dougshamoo
Copy link
Copy Markdown
Contributor

@mrmlnc Hi there, thanks for all your work on this extension. I went ahead and worked up an initial implementation for #39, as I think this is an important feature (and I've started editing the wrong file one too many times :-P). Let me know what you think.

@mrmlnc mrmlnc self-assigned this Aug 8, 2017
Comment thread package.json Outdated
},
"configuration": {
"type": "object",
"title": "VSCode-Duplicate configuration",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, replace title field to Duplicate Action Configuration for consistency with other plugins.

@mrmlnc
Copy link
Copy Markdown
Owner

mrmlnc commented Aug 8, 2017

Hello, @dougshamoo,

Thanks for PR! I really appreciate it 🎉

Sorry for delay I was on vacation without access to the internet. Please, fix one comment and I'll Merge your changes.

@dougshamoo
Copy link
Copy Markdown
Contributor Author

No problem, always willing to help out with tools that I use myself. Updated. Thanks again for your work on this. Let me know if you need any more help.

@mrmlnc mrmlnc merged commit 2cc4188 into mrmlnc:master Aug 8, 2017
@mrmlnc
Copy link
Copy Markdown
Owner

mrmlnc commented Aug 8, 2017

Thanks for your help! I'll publish extension tomorrow with fix for #40.

@mrmlnc mrmlnc mentioned this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants