Closed
Conversation
859acd6 to
cf5c2f5
Compare
Owner
|
Thanks for the pull request! Your idea is correct. The same approach is used in the original I created pull request (#449) based on your idea, in which I fixed performance issues (creating regex on each filter call). Label import.time (time) time (time) memory (memory) entries (value) process.time (time)
---------------- ------------------ ----------------- ------------------ --------------- -------------------
sync current ** 10.182ms ±1.171% 105.673ms ±1.861% 10.731 MiB ±0.564% 13813 ±0.000% 152.187ms ±1.351%
sync previous ** 22.290ms ±2.121% 91.915ms ±2.063% 10.762 MiB ±0.550% 13813 ±0.000% 150.477ms ±1.455% |
Author
|
Thanks @mrmlnc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #441
What changes did you make? (Give an overview)
Use only absolute (negated) patterns when matching against absolute paths to skip in filter.
Without this fix, when using
absolute: true, ignore patterns like**/parentmay match ancestor path parts (incwd), but not descendant path parts.Example:
When globbing
src/**/*.ts, it would not match anything, because**/parentis a match against the full path.