fix directory matching with trailing slashes#335
Closed
Trott wants to merge 2 commits intomrmlnc:masterfrom
Trott:fix-trailing-slash
Closed
fix directory matching with trailing slashes#335Trott wants to merge 2 commits intomrmlnc:masterfrom Trott:fix-trailing-slash
Trott wants to merge 2 commits intomrmlnc:masterfrom
Trott:fix-trailing-slash
Conversation
This was referenced Dec 12, 2021
Contributor
Author
|
The linter was complaining about a missing plugin for me when I tried to run it locally. Guess it works fine on CI and I should look into what was going on there.... Anyway, I'll get these lint errors fixed... |
Contributor
Author
FWIW, |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Addresses #290.
What changes did you make? (Give an overview)
I added the tests in #291, reverted the refactoring commit that caused the issue, sorted out merge conflicts during the revert, and modified the tests as appropriate. There are a small number of test cases in the smoke tests from #291 that still do not pass, but I think this is still worth landing and releasing. (FWIW, this issue is keeping me from updating to fast-glob@3 on at least one project.)