Skip to content

fix on android#296

Merged
mrmlnc merged 1 commit intomrmlnc:masterfrom
bugct:master
Dec 11, 2020
Merged

fix on android#296
mrmlnc merged 1 commit intomrmlnc:masterfrom
bugct:master

Conversation

@yozman
Copy link
Copy Markdown
Contributor

@yozman yozman commented Nov 17, 2020

What is the purpose of this pull request?

fix on android

What changes did you make? (Give an overview)

fix concurrency minimal value

@yozman yozman mentioned this pull request Nov 17, 2020
Closed
mrmlnc
mrmlnc approved these changes Dec 4, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@mrmlnc mrmlnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks 🎉

src/settings.ts
import { FileSystemAdapter, Pattern } from './types';

const CPU_COUNT = os.cpus().length;
const CPU_COUNT = Math.max(os.cpus().length, 1);
Copy link
Copy Markdown
Owner

@mrmlnc mrmlnc Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to the code above that this is a specific hack for android?

Copy link
Copy Markdown
Contributor Author

@yozman yozman Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on Android, os.cups().length equals 0

@mrmlnc mrmlnc self-assigned this Dec 4, 2020
@codekitchen
Copy link
Copy Markdown

codekitchen commented Dec 9, 2020

👍 I was going to send over this same change -- os.cpus() returns an empty array on current builds of VSCode for Apple Silicon (and possibly all Electron apps on Apple Silicon? Not sure yet). Though I'm guessing this will change eventually.

@mrmlnc
Copy link
Copy Markdown
Owner

mrmlnc commented Dec 9, 2020

Related links:

@codekitchen codekitchen mentioned this pull request Dec 9, 2020
Closed
@mrmlnc mrmlnc merged commit 800aea6 into mrmlnc:master Dec 11, 2020
@mrmlnc
Copy link
Copy Markdown
Owner

mrmlnc commented Dec 11, 2020

Thanks for the contributing 🎉

This was referenced Dec 12, 2020
Closed
Closed
@bmewburn bmewburn mentioned this pull request Dec 15, 2020
Closed
@dotsam
Copy link
Copy Markdown

dotsam commented Dec 24, 2020

@mrmlnc Would it be possible to cut a new release as this fixes issues with a number of downstream projects, and I'm sure they'd all love a stable version to point to rather than pointing to master. Thanks!

@mfcoxo mfcoxo mentioned this pull request Jan 11, 2021
Closed
@antfu
Copy link
Copy Markdown

antfu commented Jan 12, 2021

I have setup the nightly builds for fast-glob against the master branch. Until the next release, you can use it now as a workaround, see:

https://www.npmjs.com/package/@knightly/fast-glob

@mrmlnc mrmlnc added this to the 3.2.5 milestone Jan 16, 2021
@mrmlnc mrmlnc mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrmlnc mrmlnc mrmlnc approved these changes

Assignees

@mrmlnc mrmlnc

Labels

None yet

Projects

None yet

Milestone

3.2.5

Development

Successfully merging this pull request may close these issues.

5 participants

@yozman @codekitchen @mrmlnc @dotsam @antfu