WebGLBackground: Respect autoClear in XR.#26428
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Jul 31, 2023
CodyJasonBennett:background-ar
Merged
WebGLBackground: Respect autoClear in XR.#26428Mugen87 merged 1 commit intomrdoob:devfrom CodyJasonBennett:background-ar
autoClear in XR.#26428Mugen87 merged 1 commit intomrdoob:devfrom
CodyJasonBennett:background-ar
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Contributor
|
This does indeed fix my use-case (which is purely VR, environment blend mode |
autoClear in AR.
autoClear in AR.autoClear in XR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #25955
Description
Unsets
forceClearwhen handling the WebXR environment blendmode. Noticed this while testing #26160 which breaks the backgrounds-postprocessing example.I didn't move this into the
renderer.autoClear || forceClearguard as a best effort attempt to get a correct render between successive frames when manually clearing viarenderer.clear()=>renderer.render()etc.