WebGLTextures: Only use anistropic filtering with certain minFilter/magFilter combinations.#25068
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Dec 14, 2022
Merged
Conversation
…nconsistent results
Mugen87
reviewed
Dec 3, 2022
Collaborator
|
Although it's technically possible I've thought you should always use anistropic filtering with mipmapping for performance reasons (see https://paroj.github.io/gltut/Texturing/Tut15%20Anisotropy.html). So we could also check for |
Contributor
Author
|
Makes sense. I hope I get to change this next week. |
Contributor
|
Good catch! I think I'll wait on google/model-viewer#4005 until this fix is in. If it can sneak into r148, that would be much appreciated! |
Contributor
Author
|
I believe I got all cases right now; I compared behaviour with aniso=1 and =4 for a number of combinations of minFilter and magFilter (including some weird ones).
Test file: |
Mugen87
approved these changes
Dec 14, 2022
minFilter/magFilter combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #25067
Description
Fixes the above mentioned issue by not setting anisotropy if the texture has NEAREST magFilter.
I'm not sure: would this need to be applied on the new WebGPURenderer and so on as well?
This contribution is funded by Needle