Nodes: Follow three.js static property style#23562
Conversation
|
Hmm, it's up to you... But I think the style you were doing was more readable. |
I understand... But I think it pays off, maybe then we wouldn't have styles competing with each other? |
|
Hmm... It's mainly because this file, right? |
Yes, yes.. Exactly this and this too: |
|
I think I still prefer what you had... For example: import { Frustum, Matrix4, Vector3, Color, LinearEncoding } from 'three';It's impossible to tell what is a class and what is a constant. This is more readable: import { Frustum, Matrix4, Vector3, Color, LINEAR_ENCODING } from 'three';But I think what you have done is even better. For example: import { Frustum, Matrix4, Vector3, Color, Encoding } from 'three';
texture.encoding = Encoding.LINEAR;So I vote for keeping the current style in the Nodes system. @Mugen87 What do you think? |
@mrdoob Yes, there are strong arguments. I also vote for keeping the current style and change the core constants style soon. |
|
Closing then. We'll update the constants in core some day... 😅 |
Description
The static properties of Three.js don't use all caps by default like
POSITIONbutPosition. I think it's good to adaptNodeMaterialas soon as possible for this style?This contribution is funded by Google via Igalia.