examples : use event.code instead of event.keyCode#21056
Merged
mrdoob merged 2 commits intomrdoob:devfrom Jan 12, 2021
Merged
Conversation
Collaborator
|
Since the engine has not officially stopped support for IE11, it's worth mentioning that using https://caniuse.com/keyboardevent-code This is not an issue for #21055 since IE11 does not support Pointer Lock API either. |
Mugen87
approved these changes
Jan 11, 2021
donmccurdy
approved these changes
Jan 11, 2021
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following #21055
This PR continues to fix this issue in various examples by using event.code, which is layout-independant.