Skip to content

Web*RManager: Dispatch sessionstart/sessionend events#16365

Merged
mrdoob merged 4 commits intomrdoob:devfrom
takahirox:SessionEvent
Jun 3, 2019
Merged

Web*RManager: Dispatch sessionstart/sessionend events#16365
mrdoob merged 4 commits intomrdoob:devfrom
takahirox:SessionEvent

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented May 1, 2019

From #16277

This PR lets WebVR/XRManager dispatch start/endSession event on entering / existing from immersive mode.

API

renderer.vr.addEventListener( 'startSession', function ( event ) {

    console.log( 'In immersive mode.' );

} );

renderer.vr.addEventListener( 'endSession', function ( event ) {

    console.log( 'Out of immersive mode.' );

} );

Benefit

  • Common Event API no matter whether WebVR or WebXR API
  • In WebXR API users needed to watch session to detect entering/existing from immersive mode but currently we don't expose session. With this proposal we don't need to expose session.

@takahirox takahirox mentioned this pull request May 1, 2019
Closed
13 tasks
@mrdoob mrdoob added this to the r105 milestone May 2, 2019
@mrdoob
Copy link
Owner

mrdoob commented May 2, 2019

This is looking good.

Just to make sure I'm following... What is a use case for listening to these events?

@takahirox
Copy link
Collaborator Author

takahirox commented May 2, 2019 •
edited
Loading

My use case is #15840. For PostProcessing I need renderer size but the size is changed when entering or leaving from immersive mode. I watch renderer size every frame in #15840 for now but it'd be more efficient if I can watch session start/end event.

@mrdoob mrdoob modified the milestones: r105, r106 May 30, 2019
@takahirox
Copy link
Collaborator Author

takahirox commented Jun 1, 2019

Resolved the conflicts.

@mrdoob
Copy link
Owner

mrdoob commented Jun 3, 2019

Looking good!

One change though. Could you rename the events to sessionstart and sessionend?

@takahirox
Copy link
Collaborator Author

takahirox commented Jun 3, 2019

Updated

@mrdoob
Copy link
Owner

mrdoob commented Jun 3, 2019

I intentionally shifted the terms: sessionstart and sessionend. Just like touchstart, touchend, etc

@takahirox
Copy link
Collaborator Author

takahirox commented Jun 3, 2019

Yeah, I though so. And this PR looking good now?

@mrdoob mrdoob merged commit b11e46a into mrdoob:dev Jun 3, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 3, 2019

Thanks!

@mrdoob mrdoob changed the title Dispatch start/endSession event on entering/existing immersive mode Web*RManager: Dispatch sessionstart/sessionend events Jun 3, 2019
@mrdoob mrdoob mentioned this pull request Jun 3, 2019
Closed
@takahirox takahirox deleted the SessionEvent branch June 4, 2019 07:05
@takahirox takahirox mentioned this pull request Oct 15, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

2 participants

@takahirox @mrdoob