Conversation
Collaborator
|
How do we do this now? |
Owner
Author
|
That code should still work? |
Collaborator
|
ES modules have isolated scope. Their variables won't be accessible from the console unless assigned to the global scope, e.g. |
Owner
Author
|
Oh! I understand the question now. |
Owner
Author
|
Hmm... Added a note at the end of the first post. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change we can now import directly from source:
Or import the classes directly:
Example:
https://raw.githack.com/mrdoob/three.js/dev/examples/webgl2_sandbox.html
This should help for eventually clarifying dependencies and reducing bundle sizes.
Unfortunately we lose glsl syntax highlighting.
Fixes #14446
EDIT:
However... Even if it's now possible, it's not recommended. We can't guarantee backwards compatibility with that approach.