-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Evaluate ES6 classes #11552
Copy link
Copy link
Closed
Labels
Description
Why is this 'idiom' of inheritance being introduced into the code:
PointLight.prototype = Object.assign( Object.create( Light.prototype ), {
Seriously? Function(nested Function(ParentPrototype) COMMA SHOTGUN BRACKET?
The faithful two line style still in, for example, the Materials classes are much clearer and cleaner. Assign the prototype and then set the constructor. The end. Please don't ruin the library by catching JavaScript disease - the bizarre need to masturbate the way objects and inheritance are coded. One style throughout the library. No need to change it.
Reactions are currently unavailable