Skip to content

Laravel 11.x Compatibility#158

Merged
okaufmann merged 2 commits intompociot:masterfrom
laravel-shift:l11-compatibility
Jun 18, 2024
Merged

Laravel 11.x Compatibility#158
okaufmann merged 2 commits intompociot:masterfrom
laravel-shift:l11-compatibility

Conversation

@laravel-shift
Copy link
Copy Markdown
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/teamwork.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "mpociot/teamwork": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@mbardelmeijer
Copy link
Copy Markdown
Contributor

@okaufmann could you take a look at this PR to add Laravel 11 support to this package? Thanks! 🙏

@siarheipashkevich
Copy link
Copy Markdown

@okaufmann please take a look at this PR, thanks.

@mmccaff
Copy link
Copy Markdown

mmccaff commented Mar 29, 2024

@okaufmann @mpociot please merge this when you can. I did some basic testing using the package from Shift's "dev-l11-compatibility" branch on Laravel 10 and didn't see any issues, and all tests for L8..L11 in CI are passing. Thank you! 🙏

Update: I also tested with Laravel 11, and haven't ran into any issues.

@siarheipashkevich
Copy link
Copy Markdown

@okaufmann @mpociot please take a look at this PR.

@flymia
Copy link
Copy Markdown

flymia commented Apr 6, 2024

I second this. I would love to use this package under Laravel 11.

@neerajsohal
Copy link
Copy Markdown

Please merge this! I too have tested it with L11. It works without issues.

@okaufmann okaufmann merged commit bda53ab into mpociot:master Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants