Skip to content

Release 3.0.0 breaks ActiveSupport 7.1.6 #210

@pauldanielm

Description

@pauldanielm

I am getting the following error when running appraisal tests with connection_pool 3.0.1:

/tmp/bundler/ruby/3.2.0/gems/connection_pool-3.0.1/lib/connection_pool.rb:48:in `initialize': wrong number of arguments (given 1, expected 0) (ArgumentError)
        from /tmp/bundler/ruby/3.2.0/gems/activesupport-7.1.6/lib/active_support/cache/mem_cache_store.rb:103:in `new'
        from /tmp/bundler/ruby/3.2.0/gems/activesupport-7.1.6/lib/active_support/cache/mem_cache_store.rb:103:in `build_mem_cache'
        from /tmp/bundler/ruby/3.2.0/gems/activesupport-7.1.6/lib/active_support/cache/mem_cache_store.rb:140:in `initialize'
        from /tmp/bundler/ruby/3.2.0/gems/activesupport-7.1.6/lib/active_support/cache.rb:94:in `new'
        from /tmp/bundler/ruby/3.2.0/gems/activesupport-7.1.6/lib/active_support/cache.rb:94:in `lookup_store'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/application/bootstrap.rb:80:in `block in <module:Bootstrap>'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/initializable.rb:32:in `instance_exec'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/initializable.rb:32:in `run'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/initializable.rb:61:in `block in run_initializers'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:231:in `block in tsort_each'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:353:in `block (2 levels) in each_strongly_connected_component'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:434:in `each_strongly_connected_component_from'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:352:in `block in each_strongly_connected_component'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `each'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `call'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `each_strongly_connected_component'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:229:in `tsort_each'
        from /tmp/bundler/ruby/3.2.0/gems/tsort-0.2.0/lib/tsort.rb:208:in `tsort_each'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/initializable.rb:60:in `run_initializers'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/application.rb:426:in `initialize!'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/railtie.rb:226:in `public_send'
        from /tmp/bundler/ruby/3.2.0/gems/railties-7.1.6/lib/rails/railtie.rb:226:in `method_missing'
<< remainder redacted >>

Which seems to be a result of this change in 3.0.0: https://github.com/mperham/connection_pool/blame/main/lib/connection_pool.rb#L48.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions