internal/btf/btf_test.go (2)

18-39: Consider stubbing saveDataToFileFunc for full isolation.

The test successfully eliminates network dependencies, but saveDataToFileFunc remains unstubbed, meaning the test still performs file I/O. While this verifies file creation (line 82: assert.FileExists), stubbing it would provide complete isolation and faster tests.

If full isolation is desired, add:

 	origHTTPGet := httpGetFunc
 	origDecompress := decompressXzReaderFunc
 	origLoadSpec := loadSpecFunc
+	origSaveData := saveDataToFileFunc
 	httpGetFunc = func(ctx context.Context, url string) (*http.Response, error) {
 		return &http.Response{
 			StatusCode: http.StatusOK,
 			Body:       io.NopCloser(strings.NewReader("stub")),
 		}, nil
 	}
 	decompressXzReaderFunc = func(src io.Reader) ([]byte, error) {
 		return []byte("stub"), nil
 	}
+	saveDataToFileFunc = func(data []byte, path string) error {
+		// Stub: no-op or minimal file creation
+		return nil
+	}
 	loadSpecFunc = func(p string) (*ebpfbtf.Spec, string, error) {
 		return dummySpec, p, nil
 	}
 	t.Cleanup(func() {
 		httpGetFunc = origHTTPGet
 		decompressXzReaderFunc = origDecompress
 		loadSpecFunc = origLoadSpec
+		saveDataToFileFunc = origSaveData
 	})

Note: If you stub saveDataToFileFunc, you may need to adjust the assert.FileExists expectation or create the file in the stub.

---

89-105: Consider stubbing saveDataToFileFunc for full isolation.

Similar to Test_loadSpecFromBTFHub, this test eliminates network dependencies but saveDataToFileFunc remains unstubbed. For complete isolation and faster tests, consider stubbing it.

Apply the same pattern as suggested for Test_loadSpecFromBTFHub:

 	origHTTPGet := httpGetFunc
 	origLoadSpec := loadSpecFunc
+	origSaveData := saveDataToFileFunc
 	httpGetFunc = func(ctx context.Context, url string) (*http.Response, error) {
 		return &http.Response{
 			StatusCode: http.StatusOK,
 			Body:       io.NopCloser(strings.NewReader("stub")),
 		}, nil
 	}
+	saveDataToFileFunc = func(data []byte, path string) error {
+		return nil
+	}
 	loadSpecFunc = func(p string) (*ebpfbtf.Spec, string, error) {
 		return dummySpec, p, nil
 	}
 	t.Cleanup(func() {
 		httpGetFunc = origHTTPGet
 		loadSpecFunc = origLoadSpec
+		saveDataToFileFunc = origSaveData
 	})

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro