Skip to content

Commit f26b1e2

Browse files
Bug 1855045 - [remote] Add basic support for file unhandledPromptBehavior in BiDi and geckodriver r=geckodriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D272311
1 parent 725f45a commit f26b1e2

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

remote/shared/webdriver/UserPromptHandler.sys.mjs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ export const PromptTypes = {
6565
// specifying the unhandlePromptBehavior capability with a map containing a
6666
// "default" entry. See FALLBACK_DEFAULT_PROMPT_TYPE.
6767
Default: "default",
68+
// A file picker dialog
69+
File: "file",
6870
// A simple prompt dialog
6971
Prompt: "prompt",
7072
};

testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/accept.py.ini

Lines changed: 0 additions & 4 deletions
This file was deleted.

testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/dismiss.py.ini

Lines changed: 0 additions & 4 deletions
This file was deleted.

testing/web-platform/meta/webdriver/tests/bidi/session/capabilities/unhandled_prompt_behavior/file/ignore.py.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313

1414
[test_file_ignore]
1515
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1999693
16-
expected: ERROR
16+
expected: FAIL

testing/webdriver/src/capabilities.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ impl SpecNewSessionParameters {
424424
| x @ "beforeUnload"
425425
| x @ "confirm"
426426
| x @ "default"
427+
| x @ "file"
427428
| x @ "prompt" => {
428429
let behavior = try_opt!(
429430
value.as_str(),
@@ -756,7 +757,7 @@ mod tests {
756757
assert!(validate_prompt_behavior(json!("foo")).is_err());
757758

758759
// capability as object
759-
let types = ["alert", "beforeUnload", "confirm", "default", "prompt"];
760+
let types = ["alert", "beforeUnload", "confirm", "default", "file", "prompt"];
760761
let handlers = [
761762
"accept",
762763
"accept and notify",

0 commit comments

Comments
 (0)