Bug 1707584 - part4 : implement :muted pseudo class. r=media-playback-reviewers,firefox-style-system-reviewers,emilio,chunmin

alastor0325 · alastor0325 · commit cc9c51c3dd5c · 2026-02-05T21:28:21.000Z
This patch implements :muted [1] for media element. [1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-muted Differential Revision: https://phabricator.services.mozilla.com/D281040
diff --git a/dom/base/rust/lib.rs b/dom/base/rust/lib.rs
@@ -7,7 +7,7 @@
 use bitflags::bitflags;
 use malloc_size_of::malloc_size_of_is_0;
 
-pub const HEADING_LEVEL_OFFSET: usize = 56;
+pub const HEADING_LEVEL_OFFSET: usize = 57;
 
 bitflags! {
     /// Event-based element states.
@@ -152,6 +152,8 @@ bitflags! {
         const BUFFERING = 1u64 << 54;
         /// https://html.spec.whatwg.org/multipage/semantics-other.html#selector-stalled
         const STALLED = 1u64 << 55;
+        /// https://html.spec.whatwg.org/multipage/semantics-other.html#selector-muted
+        const MUTED = 1u64 << 56;
         /// https://drafts.csswg.org/selectors-5/#headings
         /// These 4 bits are used to pack the elements heading level into the element state
         /// Heading levels can be from 1-9 so 4 bits allows us to express the full range.
diff --git a/dom/media/mediaelement/HTMLMediaElement.cpp b/dom/media/mediaelement/HTMLMediaElement.cpp
@@ -3718,6 +3718,8 @@ void HTMLMediaElement::SetMutedInternal(uint32_t aMuted) {
     return;
   }
 
+  // https://html.spec.whatwg.org/multipage/semantics-other.html#selector-muted
+  SetStates(ElementState::MUTED, mMuted & MUTED_BY_CONTENT);
   SetVolumeInternal();
 }
 
diff --git a/servo/components/style/gecko/non_ts_pseudo_class_list.rs b/servo/components/style/gecko/non_ts_pseudo_class_list.rs
@@ -98,6 +98,7 @@ macro_rules! apply_non_ts_list {
                 ("seeking", Seeking, SEEKING, _),
                 ("buffering", Buffering, BUFFERING, _),
                 ("stalled", Stalled, STALLED, _),
+                ("muted", Muted, MUTED, _),
 
 
                 // NOTE(emilio): Pseudo-classes below only depend on document state, and thus
diff --git a/servo/components/style/gecko/selector_parser.rs b/servo/components/style/gecko/selector_parser.rs
@@ -229,7 +229,7 @@ impl NonTSPseudoClass {
         }
         if matches!(
             *self,
-            Self::Playing | Self::Paused | Self::Seeking | Self::Buffering | Self::Stalled
+            Self::Playing | Self::Paused | Self::Seeking | Self::Buffering | Self::Stalled | Self::Muted
         ) {
             return static_prefs::pref!("dom.media.pseudo-classes.enabled");
         }
diff --git a/servo/components/style/gecko/wrapper.rs b/servo/components/style/gecko/wrapper.rs
@@ -2088,7 +2088,8 @@ impl<'le> ::selectors::Element for GeckoElement<'le> {
             | NonTSPseudoClass::MozSuppressForPrintSelection
             | NonTSPseudoClass::Seeking
             | NonTSPseudoClass::Buffering
-            | NonTSPseudoClass::Stalled => {
+            | NonTSPseudoClass::Stalled
+            | NonTSPseudoClass::Muted => {
                 self.state().intersects(pseudo_class.state_flag())
             },
             NonTSPseudoClass::Paused => self.is_html_media_element() && self.state().intersects(ElementState::PAUSED),
diff --git a/testing/web-platform/meta/css/selectors/invalidation/media-pseudo-classes-in-has.html.ini b/testing/web-platform/meta/css/selectors/invalidation/media-pseudo-classes-in-has.html.ini
@@ -1,4 +1,2 @@
 [media-pseudo-classes-in-has.html]
   prefs: [dom.media.pseudo-classes.enabled:true]
-  [Test :muted pseudo-class]
-    expected: FAIL
diff --git a/testing/web-platform/meta/css/selectors/media/sound-state.html.ini b/testing/web-platform/meta/css/selectors/media/sound-state.html.ini
@@ -3,6 +3,3 @@
     if (os == "android") and fission: [OK, TIMEOUT]
   [Test :pseudo-class syntax is supported without throwing a SyntaxError]
     expected: FAIL
-
-  [Test :muted pseudo-class]
-    expected: FAIL

Original file line number	Diff line number	Diff line change
`@@ -3718,6 +3718,8 @@ void HTMLMediaElement::SetMutedInternal(uint32_t aMuted) {`
`3718`	`3718`	`return;`
`3719`	`3719`	`}`
`3720`	`3720`
	`3721`	`+ // https://html.spec.whatwg.org/multipage/semantics-other.html#selector-muted`
	`3722`	`+ SetStates(ElementState::MUTED, mMuted & MUTED_BY_CONTENT);`
`3721`	`3723`	`SetVolumeInternal();`
`3722`	`3724`	`}`
`3723`	`3725`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ impl NonTSPseudoClass {`
`229`	`229`	`}`
`230`	`230`	`if matches!(`
`231`	`231`	`*self,`
`232`		`- Self::Playing \| Self::Paused \| Self::Seeking \| Self::Buffering \| Self::Stalled`
	`232`	`+ Self::Playing \| Self::Paused \| Self::Seeking \| Self::Buffering \| Self::Stalled \| Self::Muted`
`233`	`233`	`) {`
`234`	`234`	`return static_prefs::pref!("dom.media.pseudo-classes.enabled");`
`235`	`235`	`}`