Bug 1916522 - [webdriver-bidi] The "session.new" command has to return the "setWindowRect" capability. r=Sasha

whimboo · whimboo · commit 9d4b13533904 · 2025-12-05T21:39:58.000Z
Differential Revision: https://phabricator.services.mozilla.com/D275211
diff --git a/remote/shared/webdriver/Capabilities.sys.mjs b/remote/shared/webdriver/Capabilities.sys.mjs
@@ -500,6 +500,7 @@ export class Capabilities extends Map {
       ["browserVersion", lazy.AppInfo.version],
       ["platformName", getWebDriverPlatformName()],
       ["proxy", new ProxyConfiguration()],
+      ["setWindowRect", !lazy.AppInfo.isAndroid],
       ["unhandledPromptBehavior", new lazy.UserPromptHandler()],
       ["userAgent", lazy.userAgent],
 
@@ -517,9 +518,9 @@ export class Capabilities extends Map {
       defaults.push(
         ["pageLoadStrategy", PageLoadStrategy.Normal],
         ["timeouts", new Timeouts()],
-        ["setWindowRect", !lazy.AppInfo.isAndroid],
         ["strictFileInteractability", false],
 
+        // Gecko specific capabilities
         ["moz:accessibilityChecks", false],
         ["moz:webdriverClick", true],
         ["moz:windowless", false]
diff --git a/remote/shared/webdriver/test/xpcshell/test_Capabilities.js b/remote/shared/webdriver/test/xpcshell/test_Capabilities.js
@@ -426,7 +426,7 @@ add_task(function test_Capabilities_ctor_bidi() {
   equal(false, caps.get("acceptInsecureCerts"));
   ok(!caps.has("timeouts"));
   ok(caps.get("proxy") instanceof ProxyConfiguration);
-  ok(!caps.has("setWindowRect"));
+  ok(caps.has("setWindowRect"));
   ok(!caps.has("strictFileInteractability"));
   ok(!caps.has("webSocketUrl"));
 
diff --git a/testing/web-platform/mozilla/tests/webdriver/bidi/session/new/response.py b/testing/web-platform/mozilla/tests/webdriver/bidi/session/new/response.py
@@ -26,6 +26,7 @@ async def test_capability_type(new_session, add_browser_capabilities):
         ("browserVersion", str),
         ("platformName", str),
         ("proxy", dict),
+        ("setWindowRect", bool),
         ("userAgent", str),
     ]
 

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ async def test_capability_type(new_session, add_browser_capabilities):`
`26`	`26`	`("browserVersion", str),`
`27`	`27`	`("platformName", str),`
`28`	`28`	`("proxy", dict),`
	`29`	`+ ("setWindowRect", bool),`
`29`	`30`	`("userAgent", str),`
`30`	`31`	`]`
`31`	`32`