Add configuration for addon signing pipeline#47
Merged
rehandalal merged 1 commit intomozilla-extensions:masterfrom Apr 9, 2020
rehandalal:tc-for-signing
Merged
Add configuration for addon signing pipeline#47rehandalal merged 1 commit intomozilla-extensions:masterfrom rehandalal:tc-for-signing
rehandalal merged 1 commit intomozilla-extensions:masterfrom
rehandalal:tc-for-signing
Conversation
rehandalal
commented
Apr 9, 2020
| "build": "npm-run-all clean build:extension", | ||
| "build": "npm-run-all clean build:extension build:finalize", | ||
| "build:extension": "web-ext build -s ./extension/ --overwrite-dest", | ||
| "build:finalize": "mv web-ext-artifacts/*.zip web-ext-artifacts/remote-settings-devtools.xpi", |
Contributor
Author
There was a problem hiding this comment.
this is required because we need the version number to not be in the filename or we cannot target the output file in the signing pipeline
leplatrem
approved these changes
Apr 9, 2020
Contributor
leplatrem
left a comment
There was a problem hiding this comment.
I mean I just hope to never having to debug it alone 😄
Contributor
Author
|
haha its a direct copy over from https://github.com/mozilla-extensions/xpi-template. you shouldn't ever have to debug it, you may just have to copy over the latest files from there if it stops working, but we're also going to find a way to reduce all this boilerplate in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the boilerplate required to integrate with TaskCluster to allow the use of the addon signing pipeline.
r?