Skip to content

Polish apparence after redesign of #209#221

Merged
leplatrem merged 8 commits intomasterfrom
apparence-fixes
Jun 3, 2024
Merged

Polish apparence after redesign of #209#221
leplatrem merged 8 commits intomasterfrom
apparence-fixes

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem commented May 30, 2024

Follow-up of #209

I was playing with the UI before tagging it, and found some apparence inconsistencies, that this PR addresses

Easier to review by commit

Header bar elements do not fill space on empty profile

Screenshot 2024-05-30 at 10 38 24

Header grows vertically when history grows

And has default left padding on <ul> which decenters its elements horizontally

Screenshot 2024-05-30 at 10 39 35

Select does not have same apparence as buttons

Not same margins, not centered...

Screenshot 2024-05-30 at 10 40 47

Paddings between sections are inconsistent

Screenshot 2024-05-30 at 10 41 37

Now

On empty profile:

Screenshot 2024-05-30 at 10 48 16

With sync history:

Screenshot 2024-05-30 at 10 49 28

On small windows
Screenshot 2024-05-30 at 11 13 56

@leplatrem leplatrem requested a review from alexcottner May 30, 2024 15:48
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good polish

@leplatrem leplatrem merged commit 2b1b284 into master Jun 3, 2024
@leplatrem leplatrem deleted the apparence-fixes branch June 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants