Make clearing local data also clear the attachment cache (#191).#193
Merged
leplatrem merged 1 commit intomozilla-extensions:masterfrom Apr 19, 2024
Merged
Make clearing local data also clear the attachment cache (#191).#193leplatrem merged 1 commit intomozilla-extensions:masterfrom
leplatrem merged 1 commit intomozilla-extensions:masterfrom
Conversation
Standard8
commented
Apr 18, 2024
| await (await client.openCollection()).clear(); | ||
| } else { | ||
| await client.db.clear(); | ||
| await client.attachments.prune([]); |
Contributor
Author
There was a problem hiding this comment.
Note: the empty array is required, as otherwise the call fails due to calling .includes() on an undefined value.
leplatrem
approved these changes
Apr 19, 2024
Contributor
leplatrem
left a comment
There was a problem hiding this comment.
Pruning was introduced in Fx 110 https://bugzilla.mozilla.org/show_bug.cgi?id=1763626
and we have "strict_min_version": "112.0", so we're good here 👌
Thank you @Standard8 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This calls
attachments.prune()after clearing the database, which will remove all the attachments as there's no references in the database and so it will think they have all expired.