Skip to content

chore: convert stable diffusion to submodule#818

Merged
njbrake merged 16 commits intomainfrom
brake/sd_submodule
Nov 3, 2025
Merged

chore: convert stable diffusion to submodule#818
njbrake merged 16 commits intomainfrom
brake/sd_submodule

Conversation

@njbrake
Copy link
Copy Markdown
Collaborator

@njbrake njbrake commented Nov 3, 2025

Following the conversion of whisper.cpp to a submodule, this converts stable-diffusion to a submodule as well.

How to test:

# Check out this branch, run `make setup`  (this will setup up all the submodules and apply the patches)
make setup
# Git clone another copy
git clone git@github.com:mozilla-ai/llamafile.git tmp_copy
rm -rf tmp_copy/stable-diffusion.cpp
cp -r stable-diffusion.cpp tmp_copy
cd tmp_copy
git status

@njbrake njbrake requested a review from aittalam November 3, 2025 15:50
Base automatically changed from brake/whisper_submodule to main November 3, 2025 18:12
Copy link
Copy Markdown
Member

@aittalam aittalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified 1:1 correspondence with original code. As this relies on the previous PR for CI and setup, everything else (basically the patch itself) LGTM. Thanks!

@github-actions github-actions bot added the devops label Nov 3, 2025
@njbrake njbrake merged commit 7ee25fe into main Nov 3, 2025
2 of 3 checks passed
@njbrake njbrake deleted the brake/sd_submodule branch November 3, 2025 18:48
@njbrake njbrake linked an issue Nov 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable Diffusion as Submodule

2 participants