Accept array in chat message content field#760
Merged
cjpais merged 1 commit intomozilla-ai:mainfrom Jun 30, 2025
Merged
Conversation
mofosyne
approved these changes
Jun 4, 2025
Collaborator
mofosyne
left a comment
There was a problem hiding this comment.
Looks reasonable and code changes appear to match intent. Approving but will wait for others to double check.
Collaborator
|
I'll try to give this a test this week. |
Collaborator
|
Tested this and it seems to work. Matches OpenAI spec for the 'text' type. Pulling it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
contentfield in a user message may be an array instead of a plain string. This case is handled properly by llama.cpp and all OpenAI-compatible public services I tried. More specifically, I encountered this issue when trying to use llamafile with Smart Composer Obsidian extension which formats messages in such an array.With these changes, both server versions (regular and --v2) work properly with the above format.