Preserve URL path when building relative URLs in JS#733
Merged
cjpais merged 1 commit intomozilla-ai:mainfrom Apr 9, 2025
Merged
Preserve URL path when building relative URLs in JS#733cjpais merged 1 commit intomozilla-ai:mainfrom
cjpais merged 1 commit intomozilla-ai:mainfrom
Conversation
dmcardle
commented
Mar 29, 2025
| if (!generation_settings) { | ||
| const url_prefix = config.url_prefix || ""; | ||
| const props = await fetch(`${url_prefix}/props`).then(r => r.json()); | ||
| const props = await fetch(buildUrl(url_prefix, 'props')).then(r => r.json()); |
Contributor
Author
There was a problem hiding this comment.
I just updated this one mechanically, but couldn't figure out how to test it. Upon further inspection, I can't find any references to llamaModelInfo in the repo. Maybe it should just be deleted?
Contributor
Author
Collaborator
|
ahh ty, i will take a look, might be later in the week after i get 0.9.2 out, but i will try to get a patch with 0.9.3 with this in it after |
Contributor
Author
|
Awesome, thank you! |
It's necessary to preserve the path because the server might be hosted under a subdirectory, specified by `--url-prefix`. Fixes mozilla-ai#732
b699214 to
b49946f
Compare
Contributor
Author
|
Ping @cjpais, but no rush :) |
Collaborator
|
I'll test and get it in tomorrow! |
Collaborator
|
thanks for this, tested and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's necessary to preserve the path because the server might be hosted under a subdirectory, specified by
--url-prefix.Fixes #732