Avoid streaming incomplete UTF-8 characters#727
Merged
cjpais merged 1 commit intomozilla-ai:mainfrom Mar 24, 2025
Merged
Conversation
Some characters, like the chinese fù is sometimes returned as two tokens, as "\u00e8\u00b5" and "\u008b" in this case. This is also depends on the model, but when it happens, for example with DeepSeek R1, we have to wait for the character to be complete and send it only then. This resolves mozilla-ai#722 and mozilla-ai#646
Contributor
Author
Collaborator
|
I've tested this and it works. We may want to modify the function slightly later, but for now it works from my basic testing, so pulling it in. Thanks so much for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some characters, like the chinese fù is sometimes returned as two tokens, as "\u00e8\u00b5" and "\u008b" in this case.
This is also depends on the model, but when it happens, for example with DeepSeek R1, we have to wait for the character to be complete and send it only then.
This resolves #722 and #646