add stable-diffusion.cpp to install target (fix #580)#635
Merged
cjpais merged 1 commit intomozilla-ai:mainfrom Mar 14, 2025
Merged
add stable-diffusion.cpp to install target (fix #580)#635cjpais merged 1 commit intomozilla-ai:mainfrom
cjpais merged 1 commit intomozilla-ai:mainfrom
Conversation
Collaborator
|
will test but likely to pull in if it's not already fixed |
Collaborator
|
@rgroesslinger can you still replicate this issue? I just checked and I cannot. I will close if it's already solved. |
Contributor
Author
|
Still happening here with current main branch, maybe someone else who came across this can confirm. Applying the change from the patch still fixes this for me. If there is anything else I can do to help, let me know. |
Collaborator
|
That's fine, I'll pull it in. I didn't see any issue building on my machine when I pulled it, so we'll use it as a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "install" target of the Makefile was missing stable-diffusion.cpp so on a clean checkout "make install" fails like reported in #580. With this patch clean checkouts can do "make install" without error and have a working sdfile executable.