fix: wrap onRequestFinished to use promises#250
Merged
Rob--W merged 1 commit intomozilla:masterfrom Dec 10, 2020
dgp1130:get-content
Merged
fix: wrap onRequestFinished to use promises#250Rob--W merged 1 commit intomozilla:masterfrom dgp1130:get-content
onRequestFinished to use promises#250Rob--W merged 1 commit intomozilla:masterfrom
dgp1130:get-content
Conversation
Contributor
Author
|
CI seems to be having a versioning error with Chrome that seems to be unrelated to this PR? |
Rob--W
requested changes
Dec 8, 2020
Member
I'll take care of that in #251 |
Rob--W
requested changes
Dec 9, 2020
Rob--W
approved these changes
Dec 9, 2020
Member
Rob--W
left a comment
There was a problem hiding this comment.
LGTM thanks. I'll merge it after the other PR that unbreaks the build is merged.
18 tasks
Member
|
The other PR got approved and merged. Could you rebase and update the PR so we can get a green CI build? |
Fixes #249. This updates `browser.devtools.network.onRequestFinished` to emit an object with a promisified `getContent()` property. This brings the polyfill implementation in line with Firefox's implementation, although MDN documentation is still inaccurate at the moment. Also updates some out of date documentation with `makeCallback()` and `wrapAsyncFunction()`.
Contributor
Author
|
Rebased and got a green CI, thanks for fixing that. Should be ready to merge. |
Member
|
Thanks for the report and patch! |
|
Thanks so much for the patch, @dgp1130! Your contribution has been added to our recognition wiki. Take care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249.
This updates
browser.devtools.network.onRequestFinishedto emit anobject with a promisified
getContent()property. This brings thepolyfill implementation in line with Firefox's implementation, although
documentation is still inaccurate at the moment.
Also updates some out of date documentation with
makeCallback().I tested this in my own Chrome extension and it appears to work as expected.