Skip to content

Removed runtime.getBrowserInfo() #200

Merged
Rob--W merged 2 commits intomozilla:masterfrom
Shubhamchinda:issue/125
Aug 1, 2019
Merged

Removed runtime.getBrowserInfo() #200
Rob--W merged 2 commits intomozilla:masterfrom
Shubhamchinda:issue/125

Conversation

@Shubhamchinda
Copy link
Contributor

@Shubhamchinda Shubhamchinda commented Aug 1, 2019

Fixes #184

@Rob--W , Let me know if other changes are required. :)

Thanks a lot!

"minArgs": 0,
"maxArgs": 0
},
"getBrowserInfo": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change that should be kept. All other removals from this PR should be undone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh Sorry!
I've updated it.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@Rob--W Rob--W merged commit 3929b9f into mozilla:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime.getBrowserInfo() should not be in api-metadata.json

2 participants