docs(README): Add suggested webpack usage#194
Merged
rpl merged 4 commits intomozilla:masterfrom Aug 1, 2019
fregante:webpack
Merged
docs(README): Add suggested webpack usage#194rpl merged 4 commits intomozilla:masterfrom fregante:webpack
rpl merged 4 commits intomozilla:masterfrom
fregante:webpack
Conversation
Rob--W
reviewed
Jul 25, 2019
Member
Rob--W
left a comment
There was a problem hiding this comment.
Prepend docs(README): to your commit title.
Member
|
Thanks for the changes. I will discuss this PR with rpl next Thursday. |
rpl
requested changes
Aug 1, 2019
Member
rpl
left a comment
There was a problem hiding this comment.
Looks good to me too, just a couple of nits:
- tweaking the title a bit
- linking the section in the TOC
Rob--W
approved these changes
Aug 1, 2019
rpl
approved these changes
Aug 1, 2019
|
Thanks so much for the update, @fregante! 🎉 Your contribution has been added to our recognition wiki. Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you! |
Contributor
Author
|
@caitmuenster I did, thanks! https://mozillians.org/en-US/u/fregante/ |
|
Thanks @fregante! Your profile is vouched. ✨ Welcome onboard! We look forward to seeing you around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156 as suggested in #156 (comment) and as used by Refined GitHub