fix: Throw error when loaded in non-extension contexts#190
Merged
Rob--W merged 1 commit intomozilla:masterfrom Jul 18, 2019
Merged
fix: Throw error when loaded in non-extension contexts#190Rob--W merged 1 commit intomozilla:masterfrom
Rob--W merged 1 commit intomozilla:masterfrom
Conversation
blimmer
approved these changes
Jun 4, 2019
blimmer
left a comment
There was a problem hiding this comment.
👍 I think this is worth doing to help people understand how to use this project.
24dc032 to
c3e1dd5
Compare
rpl
approved these changes
Jul 4, 2019
test/test-proxied-properties.js
Outdated
| // accomodate a change in the implementation of the polyfill. | ||
| // To verify that APIs are not unnecessarily initialized, the fakeChrome | ||
| // object has a "tabs" getter that fails the test upon access. | ||
| equal(lazyInitCount, 1, "chrome.runtime should be initialized because chrome.runtime.id is accessed during polyfill intiialization"); |
Member
There was a problem hiding this comment.
Nit, typo: intiialization -> initialization
c3e1dd5 to
c376018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186