fix: Remove webpack and webpack-cli dependencies#614
Conversation
Changes made in mozilla#597 accidentally resulted in `webpack` and `webpack-cli` being added as dependencies in the manifest of the published package. This problem can be seen in v0.11.0. For more information, see mozilla#604. `webpack` and `webpack-cli` are used for bundler smoke tests that are run in CI. Rather than being installed during CI, these dependencies are now included in `devDependencies`. A new npm script has been added for running this script as well, to ensure that these dependencies are on the PATH when this script is run. The CircleCI config and the contributor docs have been updated to use the new npm script. You can test it by running `npm run test-module-bundlers-smoketest`. Fixes mozilla#604
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
=======================================
Coverage 90.71% 90.71%
=======================================
Files 1 1
Lines 140 140
=======================================
Hits 127 127
Misses 13 13 ☔ View full report in Codecov by Sentry. |
| run_test_bundlers: | ||
| description: rerun unit tests on webpack and browserify bundled files | ||
| steps: | ||
| - run: npm install browserify webpack webpack-cli |
There was a problem hiding this comment.
The fix for the bug is to add --no-save here, as mentioned at #604 (comment)
|
Thanks for the analysis and fix. Although |
|
Thanks! Good point that |
Changes made in #597 accidentally resulted in
webpackandwebpack-clibeing added as dependencies in the manifest of the published package. This problem can be seen in v0.11.0. For more information, see #604.webpackandwebpack-cliare used for bundler smoke tests that are run in CI. Rather than being installed during CI, these dependencies are now included indevDependencies. A new npm script has been added for running this script as well, to ensure that these dependencies are on the PATH when this script is run.The CircleCI config and the contributor docs have been updated to use the new npm script. You can test it by running
npm run test-module-bundlers-smoketest.Fixes #604