Skip to content

fix: Cannot find Firefox package on device with work profile (#2857)#3146

Merged
willdurand merged 1 commit intominor-releases-7.x.xfrom
backport-user-android
May 27, 2024
Merged

fix: Cannot find Firefox package on device with work profile (#2857)#3146
willdurand merged 1 commit intominor-releases-7.x.xfrom
backport-user-android

Conversation

@willdurand
Copy link
Member

@willdurand willdurand commented May 27, 2024 •
edited
Loading

Backport to v7, see #3116 (comment)

@willdurand willdurand mentioned this pull request May 27, 2024
Closed
@willdurand
Copy link
Member Author

willdurand commented May 27, 2024 •
edited
Loading

There is a failure caused by npm audit which is not unknown: #2678 err, that's a new one. I am going to ignore it.

@willdurand willdurand requested a review from Rob--W May 27, 2024 19:03
@codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (minor-releases-7.x.x@ffcf07d). Learn more about missing BASE report.

❗ Current head 79f3fff differs from pull request most recent head 241acd8

Please upload reports for the commit 241acd8 to get more accurate results.

Additional details and impacted files 
@@                   Coverage Diff                   @@
##             minor-releases-7.x.x    #3146   +/-   ##
=======================================================
  Coverage                        ?   99.52%           
=======================================================
  Files                           ?       32           
  Lines                           ?     1686           
  Branches                        ?        0           
=======================================================
  Hits                            ?     1678           
  Misses                          ?        8           
  Partials                        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rob--W
Rob--W approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because of trivial backport.

The PR also includes an advisory ignore. Was that intentional? Would you consider moving the ignore to a separate pr+commit to untangle it from this unrelated PR?

@willdurand willdurand force-pushed the backport-user-android branch from 79f3fff to 241acd8 Compare May 27, 2024 19:10
@willdurand
Copy link
Member Author

willdurand commented May 27, 2024 •
edited
Loading

The PR also includes an advisory ignore. Was that intentional? Would you consider moving the ignore to a separate pr+commit to untangle it from this unrelated PR?

Sure, done.

@willdurand willdurand merged commit e1566a2 into minor-releases-7.x.x May 27, 2024
@willdurand willdurand deleted the backport-user-android branch May 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willdurand @Rob--W @lm1