fix: Remove READ_EXTERNAL_STORAGE permission requirement (backport #3018)#3023
Merged
willdurand merged 1 commit intominor-releases-7.x.xfrom Jan 19, 2024
Merged
fix: Remove READ_EXTERNAL_STORAGE permission requirement (backport #3018)#3023willdurand merged 1 commit intominor-releases-7.x.xfrom
willdurand merged 1 commit intominor-releases-7.x.xfrom
Conversation
The READ_EXTERNAL_STORAGE permission is not needed, and actually unavailable on some apps such as RefBrow. This patch removes the check and all supporting implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## minor-releases-7.x.x #3023 +/- ##
========================================================
- Coverage 99.53% 99.52% -0.01%
========================================================
Files 32 32
Lines 1707 1679 -28
========================================================
- Hits 1699 1671 -28
Misses 8 8 ☔ View full report in Codecov by Sentry. |
rpl
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The READ_EXTERNAL_STORAGE permission is not needed, and actually
unavailable on some apps such as RefBrow. This patch removes the
check and all supporting implementation.