Add Scroll-driven animations (positive)#978
Merged
Merged
Conversation
Member
Author
|
Also see Fyrd/caniuse#6956 for caniuse. |
martinthomson
approved these changes
Jan 31, 2024
tantek
requested changes
Jan 31, 2024
tantek
left a comment
Member
There was a problem hiding this comment.
This position reflects our evaluation per the issue.
One minor nit in the description, it should mention CSS properties first (which are in the draft), and drop "markup". I.e.:
s/Defines an API and markup for/Defines CSS properties and an API for
zcorpan
commented
Jan 31, 2024
Member
Author
|
@tantek fixed, and suggested that change to the spec. |
tantek
approved these changes
Feb 1, 2024
tantek
left a comment
Member
There was a problem hiding this comment.
Thank you and nicely done with the upstream spec fix as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #347