Add scrollend and overscroll events (worth prototyping).#307
Merged
dbaron merged 2 commits intomozilla:masterfrom Apr 19, 2020
Merged
Add scrollend and overscroll events (worth prototyping).#307dbaron merged 2 commits intomozilla:masterfrom
dbaron merged 2 commits intomozilla:masterfrom
Conversation
tantek
requested changes
Apr 10, 2020
Member
tantek
left a comment
There was a problem hiding this comment.
Minor typo: s/provides/provide
"The new scroll events introduced in this document provides"
should be:
"The new scroll events introduced in this document provide"
Contributor
Author
|
Ah, that typo comes straight from the abstract. |
tantek
approved these changes
Apr 10, 2020
Member
Filed a request to fix it: WICG/overscroll-scrollend-events#5 |
marcoscaceres
approved these changes
Apr 17, 2020
Contributor
marcoscaceres
left a comment
There was a problem hiding this comment.
The PR LGTM. However, this is a little bit outside my purview so I've not looked into if the proposed solution will actually address the use cases. However, having a positive signal from @smaug---- that it could work gives me confidence we can take this position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240.